Fix 'audiotrackdata'

CHANGELOG.md

@@ -1,14 +1,11 @@
 # Changelog
 
-## [0.4.1] Media Mystique: The Great Data Disappearing Act!
+## [0.4.1] It seems some Soundbars don't like music
 
 ### Fixed
 
-- Made media data (*track title*, *artist*, *length*) optional to acoomodate soundbars that don't provide this information (🥲)
+- As it seems that some soundbars don't have the 'audioTrackData' attribute
-
+  the update process now, only tries to look at the data if it is existing.
-### Added
-
-- Add translations for the english translation file
 
 ## [0.4.0] Started with an "ick", but is now packed with new features 💪
 

README.md

@@ -2,8 +2,21 @@
 
 Welcome to YASSI, the Home Assistant integration designed to bring comprehensive control over your Samsung Soundbar into your smart home ecosystem.
 
-> [!NOTE]
+> [!CAUTION]
-> Please use service calls for setting the attribute of a custom capability instead of the entity. (See #43 for more information)
+> **Soundbar Integration Issues**:
+> 
+> Samsung changed (un)intentionally? something in the SmartThings API. Therefore it is currently not possible to retrieve a status update for
+> custom capabilities like *Soundmode, EQ, Woofer and Advanced Audio settings (Nightmode, Bassmode, Voice-enhancer).
+> Other than this, the integration is working as expected.
+> 
+> **I released a new beta version where you can select for which custom capability entities should be created. If one is disabled so is the update
+> process, and therefore the error logs will disappear.**
+> 
+> It is still possible to adjust all settings of the custom capabilties, therefore the beta version features service calls for each of those.
+> For more and updated information please refer to [#26](https://github.com/samuelspagl/ha_samsung_soundbar/issues/26).
+>
+> Best Samuel ✌️
+
 
 **Table of Contents:**
 <!-- TOC -->

custom_components/samsung_soundbar/api_extension/SoundbarDevice.py

@@ -373,15 +373,11 @@ class SoundbarDevice:
 
     @property
     def media_duration(self) -> int | None:
-        attr = self.device.status.attributes.get("totalTime", None)
+        return self.device.status.attributes.get("totalTime").value
-        if attr:
-            return attr.value
 
     @property
     def media_position(self) -> int | None:
-        attr = self.device.status.attributes.get("elapsedTime", None)
+        return self.device.status.attributes.get("elapsedTime").value
-        if attr:
-            return attr.value
 
     async def media_play(self):
         await self.device.play(True)

custom_components/samsung_soundbar/manifest.json

@@ -1,16 +1,12 @@
 {
   "domain": "samsung_soundbar",
   "name": "Samsung Soundbar",
-  "codeowners": [
+  "codeowners": ["@samuelspagl"],
-    "@samuelspagl"
-  ],
   "config_flow": true,
   "documentation": "https://www.example.com",
   "integration_type": "hub",
   "iot_class": "cloud_polling",
   "issue_tracker": "https://github.com/samuelspagl/ha_samsung_soundbar/issues",
-  "requirements": [
+  "requirements": ["pysmartthings"],
-    "pysmartthings==0.7.8"
+  "version": "0.4.0"
-  ],
-  "version": "0.4.1"
 }

custom_components/samsung_soundbar/translations/de.json

@@ -107,27 +107,11 @@
     },
     "set_speaker_level":{
         "name": "Lautsprecher level verändern",
-        "description": "Verändere die Lautstärke der einzelnen Lautsprecher",
+        "description": "Verändere die Lautstärke der einzelnen Lautsprecher"
-        "fields":{
-                "speaker_identifier": {
-                    "name": "Lautsprecher",
-                    "description": "Auszuwählender Lautsprecher"
-                },
-                "level": {
-                    "name": "Lautstärke Level",
-                    "description": "Lautstärke Level zwischen -6 und 6."
-                }
-            }
     },
     "set_rear_speaker_mode":{
         "name": "Modus der hinteren Lautsprecher setzen",
-        "description": "Nutze deine Rücklautsprecher, als 'Vorder-' oder 'Rücklautsprecher'.",
+        "description": "Nutze deine Rücklautsprecher, als 'Vorder-' oder 'Rücklautsprecher'."
-        "fields":{
-                "speaker_mode": {
-                    "name": "Lautsprecher Modus",
-                    "description": "Nutze den Lautsprecher als Front oder Rear Speaker."
-                }
-            }
     },
     "set_active_voice_amplifier":{
         "name": "Stimmenverstärker setzen",

custom_components/samsung_soundbar/translations/en.json

@@ -59,95 +59,5 @@
                 "Front": "Front"
             }
         }
-    },
-    "services": {
-        "select_soundmode": {
-            "name": "Select Sound Mode",
-            "description": "Choose between 'Standard', 'Surround', 'Game', and 'Adaptive Sound'."
-        },
-        "set_woofer_level": {
-            "name": "Set Subwoofer Level",
-            "description": "Change the volume of your subwoofer.",
-            "fields": {
-                "level": {
-                    "name": "Volume Level",
-                    "description": "Subwoofer level, from -12 to +6"
-                }
-            }
-        },
-        "set_night_mode": {
-            "name": "Set Night Mode",
-            "description": "Turn 'Night Mode' on/off.",
-            "fields": {
-                "enabled": {
-                    "name": "On/Off",
-                    "description": "See name."
-                }
-            }
-        },
-        "set_bass_enhancer": {
-            "name": "Set Bass Mode",
-            "description": "Turn 'Bass Mode' on/off.",
-            "fields": {
-                "enabled": {
-                    "name": "On/Off",
-                    "description": "See name."
-                }
-            }
-        },
-        "set_voice_enhancer": {
-            "name": "Set Voice Enhancer",
-            "description": "Turn 'Voice Enhancer' on/off.",
-            "fields": {
-                "enabled": {
-                    "name": "On/Off",
-                    "description": "See name."
-                }
-            }
-        },
-        "set_speaker_level": {
-            "name": "Change Speaker Level",
-            "description": "Change the volume of individual speakers.",
-            "fields":{
-                "speaker_identifier": {
-                    "name": "Speaker Identifier",
-                    "description": "Identifier of the speaker."
-                },
-                "level": {
-                    "name": "Level",
-                    "description": "Level of the Speaker from -6 to 6."
-                }
-            }
-        },
-        "set_rear_speaker_mode": {
-            "name": "Set Rear Speaker Mode",
-            "description": "Use your rear speakers as 'Front' or 'Rear' speakers.",
-            "fields":{
-                "speaker_mode": {
-                    "name": "Speaker mode",
-                    "description": "Weather the speaker are used as rear / front speakers."
-                }
-            }
-        },
-        "set_active_voice_amplifier": {
-            "name": "Set Voice Amplifier",
-            "description": "Turn 'Voice Amplifier' on/off.",
-            "fields": {
-                "enabled": {
-                    "name": "On/Off",
-                    "description": "See name."
-                }
-            }
-        },
-        "set_space_fit_sound": {
-            "name": "Set SpaceFitSound",
-            "description": "Turn 'SpaceFitSound' on/off.",
-            "fields": {
-                "enabled": {
-                    "name": "On/Off",
-                    "description": "See name."
-                }
-            }
-        }
   }
 }